Damage effects and big mob improvement. #2622
Open
+139
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitsunemitsu
added
the
Tweak
Halonexus
force-pushed
the
scaling-effects
branch
from
48a0df0 to
e4cafac
Compare
Halonexus
force-pushed
the
scaling-effects
branch
from
e4cafac to
5b73d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds damage_effect_scale variable to hostiles that scales the visual damage effects.
Big multi tile mobs get their damage effects randomly spread out over the whole multi tile body instead of just the core.
Multi tile mobs now let you move out of the multi tile mob if it appeared on top of you.
Added the no damage visual effect when projectiles hit Warden.
Made Damage Effects work the same way for humans and hostiles with DamageEffect now as a /mob/living proc. This means hostiles will now show damage effects for any damage source.
Made clicking turfs to hit mobs not work on harm intent to let weapon swinging do its own thing.
Made both clicking turfs and weapon swings properly detect multi tile mob hitboxes.
Visually scaled Amber dusk worm when facing south and north a bit to fit 2 turfs.
Why It's Good For The Game
Looks better.
Changelog
🆑
tweak: damage effects on big mobs scale.
tweak: big mobs dont block movement if trying to get out of their hitbox.
fix: fixed damage effects from projectiles not working.
refactor: DamageEffect is now a /mob/living proc.
tweak: Clicking turfs and weapon swings can hit multi tile mobs properly.
tweak: Click turf to hit mob is disabled on harm intent to not conflict with weapon swings.
/:cl: